-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model setup for donation tracking #4838
Conversation
@danlipert still a WIP ? |
Codecov Report
@@ Coverage Diff @@
## master #4838 +/- ##
=========================================
+ Coverage 30.64% 30.7% +0.06%
=========================================
Files 216 216
Lines 17411 17425 +14
Branches 2364 2363 -1
=========================================
+ Hits 5336 5351 +15
+ Misses 11860 11859 -1
Partials 215 215
Continue to review full report at Codecov.
|
Some notes for the follow on PRs: New Grants For new grants, the donations are made in two different ways: first, for a one-time contribution to a grant, the one-time donation is made in the frontend via the splitter contract. For this use case, we'll just need to POST the donation data when the one-time contribution is made. For recurring subscriptions, donations are made with each individual contribution. For this use case, we'll need to add code to the subminer that records the donation data each time a subscription is mined. Legacy Grants For legacy grants, the donations made through recurring subscriptions and one-time contributions are treated the same - both are made via single transactions and will be recorded via POSTing the donation data when the one-time contribution is made. |
Dang you're fast! Should be good to review now, but will hold off on adding the migration until we get closer to merging. |
nevermind on holding off the migration, I see that it missing causes the tests to fail |
This reverts commit ac0248e.
Description
This PR adds the model to track the optional donations made through new and legacy grants.
Refers/Fixes
#4724
Testing
Just the model setup, so no testing (other than the syntax is clean and the server boots)