chore: update node dependencies #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed lodash vulnerability - ran npm audit fix to fix issues
Codecov Report
@@ Coverage Diff @@
## master #4837 +/- ##
=========================================
Coverage ? 30.43%
=========================================
Files ? 216
Lines ? 17382
Branches ? 2360
=========================================
Hits ? 5291
Misses ? 11882
Partials ? 209Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4837 +/- ##
=========================================
Coverage ? 30.43%
=========================================
Files ? 216
Lines ? 17333
Branches ? 2353
=========================================
Hits ? 5276
Misses ? 11848
Partials ? 209Continue to review full report at Codecov.
|
octavioamu
approved these changes
Jul 24, 2019
danlipert
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves vulnerabilities for few of the node packages
Reported over at https://github.com/gitcoinco/web/network/alerts
A few in js-sdk like css-loader + webpack require a major version upgarde which may have breaking changes. Those have been ignored for now as I wasn't sure on how to test it out