-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show 'joined Gitcoin' as an item on /activity #4836
Conversation
@@ -2804,14 +2805,7 @@ def get_various_activities(self, network='mainnet'): | |||
Q(tip__github_url__istartswith=url) | |||
) | |||
|
|||
all_activities = all_activities.filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is as much for performance / simplicity as it is for the 'joined' activity
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
=========================================
Coverage ? 30.43%
=========================================
Files ? 216
Lines ? 17335
Branches ? 2354
=========================================
Hits ? 5276
Misses ? 11850
Partials ? 209
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 30.43% 30.43% -0.01%
==========================================
Files 216 216
Lines 17333 17335 +2
Branches 2352 2353 +1
==========================================
Hits 5276 5276
- Misses 11848 11850 +2
Partials 209 209
Continue to review full report at Codecov.
|
ce1e6f6
1f1d9b8
to
ce1e6f6
Compare
Description
show 'joined Gitcoin' as an item on /activity, and on profiles
this lets us eyeball who is joining and what they're into just by looking at /activity -- also makes the network more active
Refers/Fixes
self
Testing
tested locally