Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show 'joined Gitcoin' as an item on /activity #4836

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 21, 2019

Description

show 'joined Gitcoin' as an item on /activity, and on profiles

this lets us eyeball who is joining and what they're into just by looking at /activity -- also makes the network more active

Refers/Fixes

self

Testing

tested locally

@@ -2804,14 +2805,7 @@ def get_various_activities(self, network='mainnet'):
Q(tip__github_url__istartswith=url)
)

all_activities = all_activities.filter(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is as much for performance / simplicity as it is for the 'joined' activity

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d171e40). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4836   +/-   ##
=========================================
  Coverage          ?   30.43%           
=========================================
  Files             ?      216           
  Lines             ?    17335           
  Branches          ?     2354           
=========================================
  Hits              ?     5276           
  Misses            ?    11850           
  Partials          ?      209
Impacted Files Coverage Δ
app/dashboard/views.py 14.57% <0%> (ø)
app/app/context.py 52.27% <25%> (ø)
app/dashboard/models.py 55.76% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d171e40...1f1d9b8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #4836 into master will decrease coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4836      +/-   ##
==========================================
- Coverage   30.43%   30.43%   -0.01%     
==========================================
  Files         216      216              
  Lines       17333    17335       +2     
  Branches     2352     2353       +1     
==========================================
  Hits         5276     5276              
- Misses      11848    11850       +2     
  Partials      209      209
Impacted Files Coverage Δ
app/app/context.py 52.27% <25%> (-3.83%) ⬇️
app/dashboard/models.py 55.76% <33.33%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3607f...ce1e6f6. Read the comment docs.

thelostone-mc
thelostone-mc previously approved these changes Jul 22, 2019
octavioamu
octavioamu previously approved these changes Jul 24, 2019
danlipert
danlipert previously approved these changes Jul 24, 2019
@danlipert danlipert dismissed stale reviews from octavioamu, thelostone-mc, and themself via ce1e6f6 July 24, 2019 11:26
@danlipert danlipert force-pushed the kevin/joined_activity branch from 1f1d9b8 to ce1e6f6 Compare July 24, 2019 11:26
@danlipert danlipert merged commit 887f782 into master Jul 24, 2019
@thelostone-mc thelostone-mc deleted the kevin/joined_activity branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants