-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend speed improvements - cuts landing page load time by 55% and DOMready time by 35% #4826
Changes from 3 commits
e7812a0
ea84e31
e352a3c
9d972a7
4345795
1eb3739
2a5589b
c0fea3b
32d1b52
5ff7a8f
5c4ae9f
7f50622
267676d
d933d62
2072534
907895a
561f1af
5dd81e2
9d9fd4f
205d195
fbd7963
956d551
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
{% endcomment %} | ||
{% load i18n static %} | ||
{% load i18n static compress %} | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
|
@@ -100,6 +100,13 @@ <h1 class="text-center title">{% trans "Submit Work" %}</h1> | |
{% include 'shared/footer.html' %} | ||
{% include 'shared/messages.html' %} | ||
</body> | ||
|
||
<!-- jQuery --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is already loaded in footer_scripts.js There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{% compress js %} | ||
<script src="{% static "v2/js/lib/popper.min.js" %}"></script> | ||
<script src="{% static "v2/js/lib/bootstrap.min.js" %}" crossorigin="anonymous"></script> | ||
{% endcompress %} | ||
|
||
<script> | ||
$('[data-toggle="popover"]').popover() | ||
$('[data-toggle="tooltip"]').bootstrapTooltip(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
You should have received a copy of the GNU Affero General Public License | ||
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
{% endcomment %} | ||
{% load i18n static %} | ||
{% load i18n static compress %} | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
|
@@ -201,6 +201,13 @@ <h5>{% trans 'Payout Preview' %}</h5> | |
{% include 'shared/footer.html' %} | ||
{% include 'shared/messages.html' %} | ||
</body> | ||
|
||
<!-- jQuery --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is already loaded in footer_scripts.js There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it; ill factor it back into footer_scripts There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool I will wait until you finish to review it, ping me when ready There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just updated 1eb3739 |
||
{% compress js %} | ||
<script src="{% static "v2/js/lib/popper.min.js" %}"></script> | ||
<script src="{% static "v2/js/lib/bootstrap.min.js" %}" crossorigin="anonymous"></script> | ||
{% endcompress %} | ||
|
||
<script> | ||
$('[data-toggle="popover"]').popover() | ||
$('[data-toggle="tooltip"]').bootstrapTooltip(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
{% endcomment %} | ||
{% load i18n static %} | ||
{% load i18n static compress %} | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
|
@@ -109,8 +109,15 @@ <h3>{% trans "No results found." %}</h3> | |
{% include 'shared/footer_scripts.html' %} | ||
{% include 'shared/footer.html' %} | ||
{% include 'shared/messages.html' %} | ||
|
||
{% compress js %} | ||
<script src="{% static "v2/js/lib/popper.min.js" %}"></script> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is already loaded in footer_scripts.js |
||
<script src="{% static "v2/js/lib/bootstrap.min.js" %}" crossorigin="anonymous"></script> | ||
{% endcompress %} | ||
|
||
|
||
<script> | ||
let bootstrapTooltip = $.fn.tooltip.noConflict() | ||
$.fn.runTooltip = bootstrapTooltip | ||
$('[data-toggle="popover"]').popover() | ||
|
||
$('body').popover({ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
{% endcomment %} | ||
{% load i18n static email_obfuscator add_url_schema avatar_tags %} | ||
{% load i18n static email_obfuscator add_url_schema avatar_tags compress %} | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
|
@@ -251,7 +251,18 @@ <h6 class="font-weight-bold mb-3">Invite User to Bounty</h6> | |
{% include 'shared/footer.html' %} | ||
{% include 'shared/messages.html' %} | ||
|
||
{% compress js %} | ||
<script src="{% static "v2/js/lib/popper.min.js" %}"></script> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is already loaded in footer_scripts.js |
||
<script src="{% static "v2/js/lib/bootstrap.min.js" %}" crossorigin="anonymous"></script> | ||
{% endcompress %} | ||
|
||
|
||
<script> | ||
let bootstrapTooltip = $.fn.tooltip.noConflict() | ||
$.fn.runTooltip = bootstrapTooltip; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also declared in footer_scripts There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
const bootstrapModal = $.fn.modal.noConflict() | ||
$.fn.bootstrapModal = bootstrapModal | ||
|
||
$('body').bootstrapTooltip({ | ||
selector: '[data-toggle="tooltip"]' | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Django will want a migration for this (although it doesn't actually change anything in PostgreSQL...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm i can't seem to generate one
i thikn ebecause master has this change (and a subssequent migration) also