Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banner upload problems #4820

Merged
merged 5 commits into from
Jul 18, 2019
Merged

Fix banner upload problems #4820

merged 5 commits into from
Jul 18, 2019

Conversation

octavioamu
Copy link
Contributor

Description

Fix logic to use django variable
fix styles to work in any screen
change styles to look better

Refers/Fixes
Testing

thelostone-mc
thelostone-mc previously approved these changes Jul 18, 2019
@octavioamu
Copy link
Contributor Author

@iamonuwa take a look

danlipert
danlipert previously approved these changes Jul 18, 2019
@octavioamu octavioamu dismissed stale reviews from danlipert and thelostone-mc via 505c1b8 July 18, 2019 17:23
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4820   +/-   ##
=======================================
  Coverage   30.44%   30.44%           
=======================================
  Files         216      216           
  Lines       17328    17328           
  Branches     2352     2352           
=======================================
  Hits         5276     5276           
  Misses      11843    11843           
  Partials      209      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fd337...ac29faf. Read the comment docs.

@danlipert danlipert merged commit e852776 into master Jul 18, 2019
@octavioamu
Copy link
Contributor Author

image

@thelostone-mc thelostone-mc deleted the fix/banner-styles branch June 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants