Fix banner images optimizations #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4819 +/- ##
=======================================
Coverage 30.44% 30.44%
=======================================
Files 216 216
Lines 17328 17328
Branches 2352 2352
=======================================
Hits 5276 5276
Misses 11843 11843
Partials 209 209Continue to review full report at Codecov.
|
|
@iamonuwa Please take a look on this PR |
thelostone-mc
previously approved these changes
Jul 18, 2019
thelostone-mc
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were images with 2mb 3000px really not a good practice for web.
This pr recreate all the images to be 1440 px (hd screen) and optimise the sizes.
The total size was 8,3 MB and the new images total size is 2,7 MB
After I created the new images sizes I ran this optimisations to get even smaller files
Refers/Fixes
Testing