Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass network argument #4815

Merged
merged 2 commits into from
Jul 18, 2019
Merged

pass network argument #4815

merged 2 commits into from
Jul 18, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 18, 2019

Description
  • Ensures activity gets loaded based on network
  • Fixed profile banner z-index + css

Screenshot 2019-07-18 at 9 16 38 PM

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4815 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4815      +/-   ##
==========================================
- Coverage   30.44%   30.41%   -0.04%     
==========================================
  Files         216      216              
  Lines       17328    17328              
  Branches     2352     2352              
==========================================
- Hits         5276     5270       -6     
- Misses      11843    11849       +6     
  Partials      209      209
Impacted Files Coverage Δ
app/dashboard/views.py 14.57% <0%> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d961f...1cb7c41. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4815 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4815      +/-   ##
==========================================
- Coverage   30.44%   30.41%   -0.04%     
==========================================
  Files         216      216              
  Lines       17328    17328              
  Branches     2352     2352              
==========================================
- Hits         5276     5270       -6     
- Misses      11843    11849       +6     
  Partials      209      209
Impacted Files Coverage Δ
app/dashboard/views.py 14.57% <0%> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d961f...90b3a42. Read the comment docs.

danlipert
danlipert previously approved these changes Jul 18, 2019
@thelostone-mc thelostone-mc merged commit 64fd5d0 into gitcoinco:master Jul 18, 2019
@thelostone-mc thelostone-mc deleted the shit branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants