Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback usdt conversion #4813

Merged
merged 2 commits into from
Jul 18, 2019
Merged

add fallback usdt conversion #4813

merged 2 commits into from
Jul 18, 2019

Conversation

danlipert
Copy link
Contributor

Description

a previous change to a fix for incorrect token prices inadvertently broke conversion rate for some tokens

Refers/Fixes

https://github.com/gitcoinco/web/pull/4792/files

Testing

tested locally

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4813 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4813      +/-   ##
==========================================
+ Coverage   30.45%   30.46%   +0.01%     
==========================================
  Files         216      216              
  Lines       17313    17316       +3     
  Branches     2350     2350              
==========================================
+ Hits         5272     5275       +3     
  Misses      11832    11832              
  Partials      209      209
Impacted Files Coverage Δ
app/grants/models.py 57.82% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8efdb...8fa07f3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6d8efdb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4813   +/-   ##
=========================================
  Coverage          ?   30.43%           
=========================================
  Files             ?      216           
  Lines             ?    17308           
  Branches          ?     2348           
=========================================
  Hits              ?     5267           
  Misses            ?    11832           
  Partials          ?      209
Impacted Files Coverage Δ
app/grants/models.py 57.82% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8efdb...8fa07f3. Read the comment docs.

@danlipert danlipert merged commit dcf3870 into master Jul 18, 2019
@thelostone-mc thelostone-mc deleted the fix-conversion-eth branch June 27, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants