Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api results speed 2 duplicate #4812

Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 18, 2019

Description

Duplicate #4555
Raising this against master as the above one was raised against stable so that it goes through the normal deploy process

4555 should be closed after this is merged

danlipert
danlipert previously approved these changes Jul 18, 2019
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4812 into master will decrease coverage by 12.57%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4812       +/-   ##
===========================================
- Coverage   30.41%   17.83%   -12.58%     
===========================================
  Files         216      205       -11     
  Lines       17305    17237       -68     
  Branches     2348     2346        -2     
===========================================
- Hits         5264     3075     -2189     
- Misses      11832    14153     +2321     
+ Partials      209        9      -200
Impacted Files Coverage Δ
app/dashboard/models.py 38.23% <100%> (-17.5%) ⬇️
app/kudos/forms.py 0% <0%> (-100%) ⬇️
app/grants/serializers.py 0% <0%> (-100%) ⬇️
app/avatar/serializers.py 0% <0%> (-100%) ⬇️
app/grants/urls.py 0% <0%> (-100%) ⬇️
app/inbox/urls.py 0% <0%> (-100%) ⬇️
app/avatar/urls.py 0% <0%> (-100%) ⬇️
app/grants/forms.py 0% <0%> (-100%) ⬇️
app/avatar/router.py 0% <0%> (-90.91%) ⬇️
app/app/urls.py 0% <0%> (-89.37%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313da87...e66a5b8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4812 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4812      +/-   ##
==========================================
- Coverage   30.41%   30.41%   -0.01%     
==========================================
  Files         216      216              
  Lines       17305    17313       +8     
  Branches     2348     2350       +2     
==========================================
+ Hits         5264     5266       +2     
- Misses      11832    11838       +6     
  Partials      209      209
Impacted Files Coverage Δ
app/dashboard/models.py 55.92% <100%> (+0.2%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313da87...e66a5b8. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 6d8efdb into gitcoinco:master Jul 18, 2019
@thelostone-mc thelostone-mc deleted the api_results_speed-2-duplicate branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants