Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explorer filter #4810

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix explorer filter #4810

merged 1 commit into from
Jul 18, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jul 18, 2019

Description

This pr solves some issues related to bounty explorer:

  • Set applicants = all by default
  • Fix bounties duplication
  • Fix persist applicants election
  • Fix apply parameter if applicants is in the url
  • Fix on change filters collisions
Refers/Fixes

Fix #4795

Testing

Tested diff scenarios:
reset filters, query by url, change filters, reload page, reload with params, tested hackathon explorer.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4810   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         216      216           
  Lines       17305    17305           
  Branches     2348     2348           
=======================================
  Hits         5264     5264           
  Misses      11832    11832           
  Partials      209      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad0e61...a0a4e68. Read the comment docs.

@danlipert danlipert merged commit 313da87 into master Jul 18, 2019
@thelostone-mc thelostone-mc deleted the fix/explorer-filters branch June 27, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'applicants' on the /explorer field should default to "ANY"
3 participants