Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevin/site perf2 #4800

Closed
wants to merge 8 commits into from
Closed

Kevin/site perf2 #4800

wants to merge 8 commits into from

Conversation

danlipert
Copy link
Contributor

Description

Compressed images for site performance

Refers/Fixes

#4791

@owocki
Copy link
Contributor

owocki commented Jul 16, 2019

you got the PR to open! it was so big github's UI choked on the PR creation page for me :)

@danlipert
Copy link
Contributor Author

you got the PR to open! it was so big github's UI choked on the PR creation page for me :)

hah! yeah I had to try it a few times

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Had a minor doubt though ( I've left a comment for those )

app/assets/v2/css/gitcoin.css Show resolved Hide resolved
@thelostone-mc
Copy link
Member

@danlipert / @octavioamu you guys wanna sit and resolve all these before next deploy?

@owocki
Copy link
Contributor

owocki commented Jul 29, 2019

we really only need the image changes from this PR.. not the html changes (which are managed on #4826 already )

@thelostone-mc
Copy link
Member

@danlipert / @octavioamu So spent an annoying 1 hour resolving conflicts and ensuring only img compression happen

@owocki I've removed the compress + other html changes in this PR

This PR now has

  • updating src to data-src
  • compression of jquery-viewer file + all imgs

@@ -17,7 +17,7 @@
{% endcomment %}
{% load i18n static %}
<footer class="container-fluid no-gutters footer">
<div class="container footer__main">
<div class="container footer__main" data-src="{% static "v2/images/footer.png" %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jquery-unveil.js loads it iff the user scrolls down to the footer (not upon pageload)

@thelostone-mc
Copy link
Member

Closing this out and opening this up against master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants