Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4648 pull down url #4799

Merged
merged 9 commits into from
Jul 17, 2019
Merged

Issue 4648 pull down url #4799

merged 9 commits into from
Jul 17, 2019

Conversation

iamonuwa
Copy link
Contributor

Description

Fix loading data for pasted github url.

Refers/Fixes

Fixes #4648

Testing

This is a frontend issue. There is no test. To test on your end, gitcoin.co/bounty/new?source=<github_issue_url> will now load the description and title of the issue.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #4799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4799   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         216      216           
  Lines       17247    17247           
  Branches     2340     2340           
=======================================
  Hits         5246     5246           
  Misses      11793    11793           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e23f9f...cddcb82. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5f25bb6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4799   +/-   ##
=========================================
  Coverage          ?   30.42%           
=========================================
  Files             ?      216           
  Lines             ?    17276           
  Branches          ?     2345           
=========================================
  Hits              ?     5256           
  Misses            ?    11811           
  Partials          ?      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f25bb6...e6516a6. Read the comment docs.

@danlipert
Copy link
Contributor

@iamonuwa can you post a screenshot or video demonstrating the fix? thanks!

@iamonuwa
Copy link
Contributor Author

@iamonuwa can you post a screenshot or video demonstrating the fix? thanks!

Here you go https://www.dropbox.com/s/sjlprqde86iun9j/Gitcoin%20pull%20data.mp4?dl=0

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fixes!

@danlipert
Copy link
Contributor

@octavioamu please review

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@thelostone-mc thelostone-mc merged commit be24ebc into gitcoinco:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bounty/new - it doesnt pull down the desc when you paste the URL in there
4 participants