As a gitcoin admin, I'd like the mailchimp syncing to be refactored, so the load on the database is lowered and the site runs faster #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
owocki
commented
Jul 15, 2019
|
|
||
| print('/pull_to_db') | ||
|
|
||
| def sync_mailchimp_list(eses, list_id): | ||
| print("- {} emails".format(eses.count())) | ||
| for es in eses: | ||
| client = MailChimp(mc_api=settings.MAILCHIMP_API_KEY, mc_user=settings.MAILCHIMP_USER) |
There was a problem hiding this comment.
@danlipert this just seemed like a bug, client was undefiend in this method before.
Codecov Report
@@ Coverage Diff @@
## master #4798 +/- ##
==========================================
+ Coverage 30.43% 30.43% +<.01%
==========================================
Files 216 216
Lines 17335 17337 +2
Branches 2353 2353
==========================================
+ Hits 5276 5277 +1
- Misses 11850 11851 +1
Partials 209 209
Continue to review full report at Codecov.
|
danlipert
approved these changes
Jul 16, 2019
|
@octavioamu @thelostone-mc this look good to y'all? Lets get this in ASAP |
octavioamu
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implements the changes listed on #4784 (comment)
Refers/Fixes
#4784
Testing
tested locally