Fix invite to work on a bounty detail and user directory #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4781 +/- ##
==========================================
+ Coverage 30.43% 30.43% +<.01%
==========================================
Files 216 216
Lines 17272 17271 -1
Branches 2344 2344
==========================================
Hits 5256 5256
+ Misses 11808 11807 -1
Partials 208 208
Continue to review full report at Codecov.
|
thelostone-mc
previously approved these changes
Jul 17, 2019
| @@ -21,7 +21,7 @@ $('.modal-link').click(function(e) { | |||
| const sendInvites = (users) => { | |||
| let usersId = []; | |||
| let msg = $('#shareText').val(); | |||
| const url = document.issueURL; | |||
| let bountyId = document.result.pk; | |||
There was a problem hiding this comment.
Doesn't look like bountyId gets updated within this !
should we just leave it as const ?
Also should we be extra safe and do const bountyId = document.result && document.result.pk ?
thelostone-mc
approved these changes
Jul 17, 2019
danlipert
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the query to be by bounty id instead of github url, to avoid errors when the issue is duplicated
Refers/Fixes
Fix #4780
Testing
Tested locally in bounty details + users directory