Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile performance - saves 0.25 seconds by hitting the DB once total for activity tabs per profile load instead of once per activity type #4763

Merged
merged 3 commits into from
Jul 11, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 9, 2019

Description

profile performance - saves 0.25 seconds by hitting the DB once total for activity tabs per profile load instead of once per activity type

Refers/Fixes

#4620

Testing

tested locally

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #4763 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4763      +/-   ##
==========================================
- Coverage   30.41%   30.41%   -0.01%     
==========================================
  Files         216      216              
  Lines       17240    17244       +4     
  Branches     2335     2339       +4     
==========================================
  Hits         5244     5244              
- Misses      11788    11792       +4     
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/views.py 14.4% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750e86a...d39770d. Read the comment docs.

@owocki owocki merged commit 7e23f9f into master Jul 11, 2019
@thelostone-mc thelostone-mc deleted the kevin/profile_performance_5 branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants