more profile speed improvments #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
owocki
commented
Jul 9, 2019
| @@ -2641,8 +2641,7 @@ def get_eth_sum(self, sum_type='collected', network='mainnet', bounties=None): | |||
|
|
|||
| """ | |||
| eth_sum = 0 | |||
|
|
|||
| if not bounties: | |||
| if bounties is None: | |||
There was a problem hiding this comment.
if bounties.exists() was 0, then this condition was hit and we'd lookup the get_funded_bounties() again.. thus hurting performance
owocki
commented
Jul 9, 2019
| eth_sum = bounties.aggregate( | ||
| Sum('value_in_eth') | ||
| )['value_in_eth__sum'] / 10**18 | ||
| eth_sum = sum([amount for amount in bounty.values_list("value_in_eth", flat=True)]) |
There was a problem hiding this comment.
this is much faster.. 0.45 vs 0.02s
danlipert
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
more profile speed improvments (see comments inline for desc)
Refers/Fixes
#4620
Testing
tested locally