Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failing in master #4759

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Fix tests failing in master #4759

merged 5 commits into from
Jul 10, 2019

Conversation

danlipert
Copy link
Contributor

@danlipert danlipert commented Jul 9, 2019

Description

Fixes tests failures in master

Refers/Fixes

Fixes 2 issues - 1) the old grants test left EmailSubscriber objects in the database, breaking a later test. 2) The GeoIP database we use updated the entry for one of the IP addresses in our tests from Cuyahoga Falls to Tallmadge, another city 5 km away. Great. ;P

Testing

The tests now pass

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #4759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4759   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         216      216           
  Lines       17240    17240           
  Branches     2335     2335           
=======================================
  Hits         5244     5244           
  Misses      11788    11788           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc68c7a...03817fe. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #4759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4759   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         216      216           
  Lines       17240    17240           
  Branches     2335     2335           
=======================================
  Hits         5244     5244           
  Misses      11788    11788           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc68c7a...a557d5f. Read the comment docs.

@danlipert danlipert changed the title [wip, checking travis] Fix tests failing in master Fix tests failing in master Jul 9, 2019
@danlipert danlipert changed the title Fix tests failing in master Fix tests failing in master Jul 9, 2019
@danlipert danlipert merged commit 750e86a into master Jul 10, 2019
@thelostone-mc thelostone-mc deleted the test-travis branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants