-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check-In Tool (ambassador) API extension #4750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @kuhnchris - is this good to merge in? I saw some discussion about it among y'all so I wanted to double check - let me know, thanks! |
we only asked around for people to help merge, it's good from my side. :-) |
Codecov Report
@@ Coverage Diff @@
## master #4750 +/- ##
==========================================
+ Coverage 30.41% 30.44% +0.03%
==========================================
Files 216 216
Lines 17247 17255 +8
Branches 2340 2340
==========================================
+ Hits 5246 5254 +8
Misses 11793 11793
Partials 208 208
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4750 +/- ##
==========================================
+ Coverage 30.41% 30.44% +0.03%
==========================================
Files 216 216
Lines 17240 17248 +8
Branches 2335 2335
==========================================
+ Hits 5244 5252 +8
Misses 11788 11788
Partials 208 208
Continue to review full report at Codecov.
|
@kuhnchris can you fix the isort error? |
ah sure, my bad. I'll fix it in a bit! |
@kuhnchris anything you need from our side to get ready to merge? |
Yes, from my aside a.o.k. Thanks for the merge @danlipert |
Description
This PR adds a new view-set that quickly provides data for the check-in tool
Refers/Fixes
No public issues available.
Testing
checked against the mockserver.py - data is 100% compatible and usable the moment we switch it in.