Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-In Tool (ambassador) API extension #4750

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Check-In Tool (ambassador) API extension #4750

merged 8 commits into from
Jul 16, 2019

Conversation

kuhnchris
Copy link
Contributor

Description

This PR adds a new view-set that quickly provides data for the check-in tool

Refers/Fixes

No public issues available.

Testing

checked against the mockserver.py - data is 100% compatible and usable the moment we switch it in.
image

@danlipert danlipert self-requested a review July 8, 2019 13:51
danlipert
danlipert previously approved these changes Jul 8, 2019
@octavioamu octavioamu requested a review from a team July 8, 2019 13:53
octavioamu
octavioamu previously approved these changes Jul 8, 2019
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danlipert
Copy link
Contributor

Hey @kuhnchris - is this good to merge in? I saw some discussion about it among y'all so I wanted to double check - let me know, thanks!

@kuhnchris
Copy link
Contributor Author

Hey @kuhnchris - is this good to merge in? I saw some discussion about it among y'all so I wanted to double check - let me know, thanks!

we only asked around for people to help merge, it's good from my side. :-)

@danlipert danlipert requested a review from thelostone-mc as a code owner July 10, 2019 09:47
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #4750 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4750      +/-   ##
==========================================
+ Coverage   30.41%   30.44%   +0.03%     
==========================================
  Files         216      216              
  Lines       17247    17255       +8     
  Branches     2340     2340              
==========================================
+ Hits         5246     5254       +8     
  Misses      11793    11793              
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/router.py 34.66% <100%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e23f9f...04ce03d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #4750 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4750      +/-   ##
==========================================
+ Coverage   30.41%   30.44%   +0.03%     
==========================================
  Files         216      216              
  Lines       17240    17248       +8     
  Branches     2335     2335              
==========================================
+ Hits         5244     5252       +8     
  Misses      11788    11788              
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/router.py 34.66% <100%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750e86a...9d36c1d. Read the comment docs.

@danlipert
Copy link
Contributor

@kuhnchris can you fix the isort error?

@kuhnchris
Copy link
Contributor Author

@kuhnchris can you fix the isort error?

ah sure, my bad. I'll fix it in a bit!

@kuhnchris kuhnchris dismissed stale reviews from octavioamu and danlipert via 24a4b09 July 10, 2019 21:49
@rmshea
Copy link
Contributor

rmshea commented Jul 15, 2019

@kuhnchris anything you need from our side to get ready to merge?

@danlipert danlipert merged commit f8fd8d0 into gitcoinco:master Jul 16, 2019
@kuhnchris
Copy link
Contributor Author

Yes, from my aside a.o.k. Thanks for the merge @danlipert

@kuhnchris kuhnchris deleted the issue-exporer-api branch July 16, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants