sync mail every 2 hours to match script #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 216 216
Lines 17240 17240
Branches 2335 2335
=======================================
Hits 5244 5244
Misses 11788 11788
Partials 208 208Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 216 216
Lines 17240 17240
Branches 2335 2335
=======================================
Hits 5244 5244
Misses 11788 11788
Partials 208 208Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Jul 4, 2019
octavioamu
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change to the cron schedule matches the sync_mail job timing to the timing in the script itself (syncing new users from the last 2 hours here: https://github.com/gitcoinco/web/blob/master/app/marketing/management/commands/sync_mail.py#L121)
This issue was discovered when we noted our mailchimp audience list contains about half the actual user count from our platform - since the cronjob syncs new users from the database every 6 hours, and script only looks at users from the last 2 hours, we were missing 2/3 new users. The remaining 1/6 likely came from Sumo
Testing
Will monitor production infrastructure metrics one deployed