Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to resubmit kudos txns #4725

Merged
merged 4 commits into from
Jul 27, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 1, 2019

Description

adds ability to resubmit kudos airdrop txns after a recent spat of user complaints.

the reason this happens is that as the network gas prices have increased... we do not have the proper mechanisms for queuing up transactions. if someone claims a kudos, and it doesnt clear by the time the next kudos claim comes in, there is a chance they will over write each other.

Refers/Fixes

https://twitter.com/AnettRolikova/status/1144655093758943234

Testing

tested locally via command line and view the web UI

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #4725 into master will decrease coverage by <.01%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4725      +/-   ##
==========================================
- Coverage   30.64%   30.64%   -0.01%     
==========================================
  Files         216      216              
  Lines       17407    17411       +4     
  Branches     2363     2364       +1     
==========================================
+ Hits         5335     5336       +1     
- Misses      11857    11860       +3     
  Partials      215      215
Impacted Files Coverage Δ
app/kudos/views.py 21.59% <2.56%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ae26f...eca3d28. Read the comment docs.

@danlipert
Copy link
Contributor

@octavioamu @thelostone-mc

@thelostone-mc thelostone-mc merged commit fee6e60 into master Jul 27, 2019
@thelostone-mc
Copy link
Member

Thanks @owocki ^_^

@thelostone-mc thelostone-mc deleted the kevin/ability_to_resubmit_kudos_txns branch July 27, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants