chore: grant/details cleanup #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed alert to notify grant owner to switch to right metamask address. - fix breaking UI on mobile + tablet on summary section - disable change address button if address is same. - added tooltip to give more info to grant owner
thelostone-mc
added
frontend
thelostone-mc
requested review from
PixelantDesign,
danlipert,
octavioamu and
frankchen07
Codecov Report
@@ Coverage Diff @@
## master #4720 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 216 216
Lines 17223 17223
Branches 2332 2332
=======================================
Hits 5239 5239
Misses 11776 11776
Partials 208 208Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4720 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 216 216
Lines 17233 17233
Branches 2333 2333
=======================================
Hits 5242 5242
Misses 11783 11783
Partials 208 208Continue to review full report at Codecov.
|
danlipert
previously approved these changes
Jul 1, 2019
- Changed order of info to ensure contract change appears at the bottom. - Added tooltip explaining what can the grant owner can do. - Fixed up alert logic to instruct user to login with right address
thelostone-mc
force-pushed
the
grant_owner_change
branch
from
86322e6 to
683f265
Compare
|
@danlipert addressed your comments and throw in a few more changes to make UX less weird |
danlipert
suggested changes
Jul 2, 2019
danlipert
approved these changes
Jul 2, 2019
octavioamu
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
address.
Refers/Fixes
It should go in after #4719
Just cause I built it on top of that PR
Testing
Check it out HERE
UPDATE: MADE A FEW MORE CHANGES TO MAKE UX LESS WEIRD