Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code #4717

Merged
merged 3 commits into from
Jul 3, 2019
Merged

chore: remove dead code #4717

merged 3 commits into from
Jul 3, 2019

Conversation

thelostone-mc
Copy link
Member

Description

bounty/new.html is not used anywhere. removing to ensure there is
no confusion while developing

Testing

Normal bounty flow works as expected as shown HERE

bounty/new.html is not used anywhere. removing to ensure there is
no confusion while developing
@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #4717 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4717      +/-   ##
==========================================
- Coverage   30.41%   30.38%   -0.04%     
==========================================
  Files         216      216              
  Lines       17223    17223              
  Branches     2332     2332              
==========================================
- Hits         5239     5233       -6     
- Misses      11776    11782       +6     
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4f4e5...7107896. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #4717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4717   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         216      216           
  Lines       17233    17233           
  Branches     2333     2333           
=======================================
  Hits         5242     5242           
  Misses      11783    11783           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ba6b8...6c38301. Read the comment docs.

@danlipert danlipert merged commit 398d964 into gitcoinco:master Jul 3, 2019
@thelostone-mc thelostone-mc deleted the purge branch July 4, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Bounties Gitcoin Bounties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants