Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom migration + delete from all lists #4702

Merged
merged 2 commits into from
Jun 27, 2019

Conversation

danlipert
Copy link
Contributor

@danlipert danlipert commented Jun 27, 2019

Description

This change removes the custom migration for funder/hunter personas, instead relying on the cronjob to set the flags for each user. The management command can be run manually on production after deploy.

The second commit also deletes users from the additional mailchimp lists if they delete their account.

Refers/Fixes

Fixes migration errors, delete from funder and hunter lists

Testing

Tested via successful test suite run

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4702 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4702   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         216      216           
  Lines       17192    17192           
  Branches     2324     2324           
=======================================
  Hits         5232     5232           
  Misses      11753    11753           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153d9ed...b69bf00. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4702 into master will decrease coverage by 0.01%.
The diff coverage is 12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4702      +/-   ##
==========================================
- Coverage   30.43%   30.42%   -0.02%     
==========================================
  Files         216      216              
  Lines       17192    17201       +9     
  Branches     2324     2325       +1     
==========================================
+ Hits         5232     5233       +1     
- Misses      11753    11761       +8     
  Partials      207      207
Impacted Files Coverage Δ
app/marketing/views.py 12.15% <33.33%> (+0.15%) ⬆️
app/marketing/utils.py 32.65% <9.09%> (-4.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153d9ed...56f7f2d. Read the comment docs.

@danlipert danlipert marked this pull request as ready for review June 27, 2019 08:13
@danlipert danlipert changed the title remove custom migration remove custom migration + delete from all lists Jun 27, 2019
@danlipert danlipert force-pushed the fix-persona-migrations branch from cb6f2c7 to 56f7f2d Compare June 27, 2019 09:32
@thelostone-mc thelostone-mc merged commit 5fdc294 into master Jun 27, 2019
@thelostone-mc thelostone-mc deleted the fix-persona-migrations branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants