Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded .env values #4699

Merged
merged 2 commits into from
Jun 27, 2019
Merged

remove hardcoded .env values #4699

merged 2 commits into from
Jun 27, 2019

Conversation

thelostone-mc
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4699 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4699   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         216      216           
  Lines       17192    17192           
  Branches     2324     2324           
=======================================
  Hits         5232     5232           
  Misses      11753    11753           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153d9ed...2f18a35. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4699 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4699      +/-   ##
==========================================
+ Coverage   30.42%   30.43%   +0.01%     
==========================================
  Files         216      216              
  Lines       17201    17192       -9     
  Branches     2325     2324       -1     
==========================================
- Hits         5233     5232       -1     
+ Misses      11761    11753       -8     
  Partials      207      207
Impacted Files Coverage Δ
app/marketing/views.py 12% <0%> (-0.16%) ⬇️
app/marketing/utils.py 36.79% <0%> (+4.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdc294...f0031fa. Read the comment docs.

@danlipert danlipert merged commit 82e17e0 into gitcoinco:master Jun 27, 2019
@thelostone-mc thelostone-mc deleted the env branch July 4, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants