Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of GitHub #4698

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Fix spelling of GitHub #4698

merged 3 commits into from
Jun 27, 2019

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Jun 26, 2019

Description

Fix typo

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #4698 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4698      +/-   ##
==========================================
- Coverage   30.43%   30.39%   -0.04%     
==========================================
  Files         216      216              
  Lines       17192    17192              
  Branches     2324     2324              
==========================================
- Hits         5232     5226       -6     
- Misses      11753    11759       +6     
  Partials      207      207
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153d9ed...eae7228. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #4698 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4698      +/-   ##
==========================================
- Coverage   30.41%   30.39%   -0.03%     
==========================================
  Files         216      216              
  Lines       17223    17192      -31     
  Branches     2332     2324       -8     
==========================================
- Hits         5239     5226      -13     
+ Misses      11776    11759      -17     
+ Partials      208      207       -1
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/marketing/views.py 12% <0%> (-0.16%) ⬇️
app/dashboard/helpers.py 13.89% <0%> (ø) ⬆️
app/dashboard/views.py 14.4% <0%> (+0.04%) ⬆️
app/dashboard/models.py 55.88% <0%> (+0.2%) ⬆️
app/dashboard/admin.py 65.92% <0%> (+0.36%) ⬆️
app/marketing/utils.py 36.79% <0%> (+4.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e172a6...3656265. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've deleted the word as opposed to fixing the spelling ! Could you update that and squash the commits into 1 ?

thanks for pointing that out ^_^

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it 🙌

@thelostone-mc thelostone-mc merged commit 3067cbf into gitcoinco:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants