fixes the grants/new gas estimate #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4697 +/- ##
=======================================
Coverage 30.43% 30.43%
=======================================
Files 216 216
Lines 17192 17192
Branches 2324 2324
=======================================
Hits 5232 5232
Misses 11753 11753
Partials 207 207Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4697 +/- ##
=========================================
Coverage ? 30.43%
=========================================
Files ? 216
Lines ? 17192
Branches ? 2324
=========================================
Hits ? 5232
Misses ? 11753
Partials ? 207Continue to review full report at Codecov.
|
octavioamu
approved these changes
Jun 27, 2019
danlipert
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from scott:
Another bug(?) I noticed: The form says that the gas cost will be $1.98 (0.006375ETH), but when I actually submit, the cost is 10 times that: 0.06ETH. Is the gas price set too high, or is the contract just bigger than the code assumes?Refers/Fixes
https://gitcoincore.slack.com/archives/CBDTKB59A/p1561483669002300
Testing
tested locally