Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override org-name + photo #4696

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jun 26, 2019

Description

Tested it out again

Screenshot 2019-06-27 at 12 06 59 AM

@thelostone-mc
Copy link
Member Author

@danlipert / @octavioamu So

turn self.cursor.execute(sql, params)
E               django.db.utils.ProgrammingError: column dashboard_profile.admin_override_name does not exist
E               LINE 1: ...funder", "dashboard_profile"."persona_is_hunter", "dashboard...

^ that error pops up in travis and I'm not sure what the issue is

- updated models Profile & Bounty -> override name + url
- added provision in admin to enable admin overrides
- updated template to use newly added property
- update existing prop to use override name + url
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4696 into master will decrease coverage by 12.61%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #4696       +/-   ##
==========================================
- Coverage   30.42%   17.8%   -12.62%     
==========================================
  Files         216     205       -11     
  Lines       17201   17138       -63     
  Branches     2325    2327        +2     
==========================================
- Hits         5233    3052     -2181     
- Misses      11761   14077     +2316     
+ Partials      207       9      -198
Impacted Files Coverage Δ
app/dashboard/helpers.py 11.41% <ø> (-2.49%) ⬇️
app/dashboard/views.py 11.3% <0%> (-3.1%) ⬇️
app/dashboard/admin.py 65.55% <0%> (-0.37%) ⬇️
app/dashboard/models.py 37.83% <27.27%> (-18.06%) ⬇️
app/kudos/forms.py 0% <0%> (-100%) ⬇️
app/grants/serializers.py 0% <0%> (-100%) ⬇️
app/avatar/serializers.py 0% <0%> (-100%) ⬇️
app/grants/urls.py 0% <0%> (-100%) ⬇️
app/inbox/urls.py 0% <0%> (-100%) ⬇️
app/avatar/urls.py 0% <0%> (-100%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdc294...099ae2b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4696 into master will decrease coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4696      +/-   ##
==========================================
- Coverage   30.42%   30.38%   -0.04%     
==========================================
  Files         216      216              
  Lines       17201    17223      +22     
  Branches     2325     2332       +7     
==========================================
  Hits         5233     5233              
- Misses      11761    11782      +21     
- Partials      207      208       +1
Impacted Files Coverage Δ
app/dashboard/helpers.py 13.89% <ø> (ø) ⬆️
app/dashboard/views.py 14.36% <0%> (-0.05%) ⬇️
app/dashboard/admin.py 65.55% <0%> (-0.37%) ⬇️
app/dashboard/models.py 55.68% <27.27%> (-0.21%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e17e0...9f75f53. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4696 into master will decrease coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4696      +/-   ##
==========================================
- Coverage   30.42%   30.38%   -0.04%     
==========================================
  Files         216      216              
  Lines       17201    17223      +22     
  Branches     2325     2332       +7     
==========================================
  Hits         5233     5233              
- Misses      11761    11782      +21     
- Partials      207      208       +1
Impacted Files Coverage Δ
app/dashboard/helpers.py 13.89% <ø> (ø) ⬆️
app/dashboard/views.py 14.36% <0%> (-0.05%) ⬇️
app/dashboard/admin.py 65.55% <0%> (-0.37%) ⬇️
app/dashboard/models.py 55.68% <27.27%> (-0.21%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e17e0...9f75f53. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 7d1ffa7 into gitcoinco:master Jun 27, 2019
@thelostone-mc thelostone-mc deleted the weird branch July 4, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants