Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top banner animation #4690

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Add top banner animation #4690

merged 1 commit into from
Jun 26, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jun 26, 2019

Description

Add hackathon banner animation and fix topbar spacing in some pages.
Check out this video: https://embed.vidyard.com/share/jv1xYrgPP5xQcJF3iscbiz?

Refers/Fixes
Testing

tested navigating the site

@octavioamu octavioamu requested a review from a team June 26, 2019 03:43
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #4690 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4690      +/-   ##
==========================================
+ Coverage   30.39%   30.42%   +0.03%     
==========================================
  Files         216      216              
  Lines       17214    17214              
  Branches     2331     2331              
==========================================
+ Hits         5232     5238       +6     
+ Misses      11774    11768       -6     
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b46066...38899c3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #4690 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4690      +/-   ##
==========================================
+ Coverage   30.39%   30.42%   +0.03%     
==========================================
  Files         216      216              
  Lines       17214    17214              
  Branches     2331     2331              
==========================================
+ Hits         5232     5238       +6     
+ Misses      11774    11768       -6     
  Partials      208      208
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b46066...38899c3. Read the comment docs.

@thelostone-mc thelostone-mc merged commit e8e789e into master Jun 26, 2019
@thelostone-mc thelostone-mc deleted the banner-animation branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants