Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return crowdfunding payouts to sender in the scenario in which they are attached to a bounty that uses advanced payout. #4673

Merged
merged 3 commits into from
Aug 10, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 24, 2019

Description

return crowdfunding payouts to sender in the scenario in which they are attached to a bounty that uses advanced payout.

the reason for this is that it is too complicated to break up the tips to multiple recipients without being custodial of the funds. it is easier to instruct the crowdfunding person to do it at their discretion.

Refers/Fixes

https://gitcoincore.slack.com/archives/CAXQ7PT60/p1561140267081600

Testing

tested locally on my db

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #4673 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4673      +/-   ##
==========================================
+ Coverage    30.3%   30.34%   +0.03%     
==========================================
  Files         214      214              
  Lines       17142    17122      -20     
  Branches     2319     2318       -1     
==========================================
  Hits         5195     5195              
+ Misses      11740    11720      -20     
  Partials      207      207
Impacted Files Coverage Δ
...agement/commands/send_tips_for_bounty_fulfiller.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2098f26...493b385. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #4673 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4673      +/-   ##
==========================================
+ Coverage   30.89%   30.92%   +0.03%     
==========================================
  Files         217      217              
  Lines       17423    17402      -21     
  Branches     2382     2381       -1     
==========================================
  Hits         5382     5382              
+ Misses      11822    11800      -22     
- Partials      219      220       +1
Impacted Files Coverage Δ
...agement/commands/send_tips_for_bounty_fulfiller.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 14.23% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b6388...a4393b6. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 04f6d94 into master Aug 10, 2019
@thelostone-mc thelostone-mc deleted the kevin/return_to_sender branch June 27, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants