Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update banner text #4671

Merged
merged 1 commit into from
Jun 24, 2019
Merged

update banner text #4671

merged 1 commit into from
Jun 24, 2019

Conversation

thelostone-mc
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #4671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4671   +/-   ##
======================================
  Coverage    30.3%   30.3%           
======================================
  Files         214     214           
  Lines       17142   17142           
  Branches     2319    2319           
======================================
  Hits         5195    5195           
  Misses      11740   11740           
  Partials      207     207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8af58...17e7f13. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #4671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4671   +/-   ##
======================================
  Coverage    30.3%   30.3%           
======================================
  Files         214     214           
  Lines       17142   17142           
  Branches     2319    2319           
======================================
  Hits         5195    5195           
  Misses      11740   11740           
  Partials      207     207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8af58...17e7f13. Read the comment docs.

octavioamu
octavioamu approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 2098f26 into gitcoinco:master Jun 24, 2019
@thelostone-mc thelostone-mc deleted the hack branch June 24, 2019 15:03
owocki
owocki reviewed Jun 24, 2019
View reviewed changes
app/retail/templates/shared/top_nav.html
@@ -20,7 +20,7 @@
<!--- Top Row Notification -->
<div class="row bottom_notification font-caption" style="text-align: center;">
<span style="text-align: center; margin: auto;">
{% blocktrans %}<strong>The Beyond Blocks Hackathon was just announced!</strong> - A three week virtual hackathon where global developers + entrepeneurs will collaborate to push blockchain applications to new frontiers of business + technology + social change <a href="https://gitcoin.co/hackathon/beyondblocks">Sign up today</a>.{% endblocktrans %}
{% blocktrans %}<strong>The Beyond Blockchain Hackathon was just announced!</strong> - A three week virtual hackathon where global developers + entrepeneurs will collaborate to push blockchain applications to new frontiers of business + technology + social change <a href="https://gitcoin.co/hackathon/beyondblocks">Sign up today</a>.{% endblocktrans %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we edit the top_nav_salt and update the message to say "The Beyond Blockchain Hackathon has just started" ? that way ppl will see that it started today...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owocki owocki owocki left review comments

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert Awaiting requested review from danlipert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @owocki @octavioamu