Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sponsorship in The Weekly Gitcoin #4667

Merged
merged 4 commits into from
Jun 22, 2019

Conversation

coderberry
Copy link
Contributor

Add support for sponsorship placements in The Weekly Gitcoin newsletter.

image

@coderberry coderberry requested a review from danlipert June 21, 2019 15:12
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #4667 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4667      +/-   ##
==========================================
- Coverage   30.33%   30.33%   -0.01%     
==========================================
  Files         214      214              
  Lines       17122    17123       +1     
  Branches     2313     2313              
==========================================
  Hits         5194     5194              
- Misses      11721    11722       +1     
  Partials      207      207
Impacted Files Coverage Δ
app/retail/emails.py 22.33% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653d229...8138829. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #4667 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4667      +/-   ##
=========================================
- Coverage    30.3%   30.3%   -0.01%     
=========================================
  Files         214     214              
  Lines       17141   17142       +1     
  Branches     2319    2319              
=========================================
  Hits         5195    5195              
- Misses      11739   11740       +1     
  Partials      207     207
Impacted Files Coverage Δ
app/retail/emails.py 22.33% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651abf6...f178baa. Read the comment docs.

@@ -929,7 +929,6 @@ def render_start_work_applicant_expired(interest, bounty):

return response_html, response_txt, subject


Copy link
Member

@thelostone-mc thelostone-mc Jun 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need that extra line here @coderberry ! I'll take care of it this time

@thelostone-mc thelostone-mc merged commit 18baf8c into master Jun 22, 2019
@@ -30,3 +30,6 @@ GITHUB_CLIENT_SECRET=
GITHUB_APP_NAME=

INFURA_USE_V3=True

SENDGRID_API_KEY=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
Copy link
Contributor

@mbeacom mbeacom Jun 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh derp !
Haha thanks man 🙌 you da best

@thelostone-mc thelostone-mc deleted the berry/newsletter-sponsor branch July 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants