feat: add beyond_blockhain hackathon page #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4657 +/- ##
=========================================
- Coverage 30.4% 30.3% -0.11%
=========================================
Files 213 214 +1
Lines 17113 17122 +9
Branches 2312 2313 +1
=========================================
- Hits 5204 5188 -16
- Misses 11700 11727 +27
+ Partials 209 207 -2
Continue to review full report at Codecov.
|
octavioamu
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Hey @thelostone-mc I had checked the code and looks goods but just have one point, this file size is 8mb and in this case doesn't really make sense to be a svg can we create a png from that instead?
https://github.com/gitcoinco/web/blob/31c550b584bbb34e9fa1b3d452facd5eae1fbe87/app/assets/v2/images/hackathon/beyond_block/logo.svg
and
octavioamu
reviewed
Jun 19, 2019
danlipert
previously approved these changes
Jun 20, 2019
danlipert
previously approved these changes
Jun 20, 2019
- update typeform link - updated hackahton banner - updated model to add unique identifer - created config file to store sponsors list - added custom styling for the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
This should go in POST #4645
Testing
Beyond Blockchain Page
EVH Page