Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes token display not updating when creating a bounty (https://github.com/gitcoinco/web/issues/4189) #4647

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 17, 2019

Description

fixes #4189 by calling the triggerDenominationUpdate() method upon pageload

Refers/Fixes

#4189

Testing

tested locally

thelostone-mc
thelostone-mc previously approved these changes Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #4647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4647   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files         213      213           
  Lines       17098    17098           
  Branches     2311     2311           
=======================================
  Hits         5140     5140           
  Misses      11758    11758           
  Partials      200      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6005a5e...061eefd. Read the comment docs.

@danlipert danlipert changed the title fixes https://github.com/gitcoinco/web/issues/4189 fixes token display not updating when creating a bounty (https://github.com/gitcoinco/web/issues/4189) Jun 18, 2019
@danlipert danlipert merged commit 348cdfb into master Jun 18, 2019
@thelostone-mc thelostone-mc deleted the kevin/DAI_total_fix branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounty creation total sometime shows ETH instead of token
3 participants