-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: override org name + photo #4646
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
+ Coverage 30.06% 30.06% +<.01%
==========================================
Files 213 213
Lines 17098 17113 +15
Branches 2311 2317 +6
==========================================
+ Hits 5140 5145 +5
- Misses 11758 11766 +8
- Partials 200 202 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
- Coverage 30.43% 30.43% -0.01%
==========================================
Files 216 216
Lines 17188 17210 +22
Branches 2322 2329 +7
==========================================
+ Hits 5232 5238 +6
- Misses 11749 11764 +15
- Partials 207 208 +1
Continue to review full report at Codecov.
|
- updated models Profile & Bounty -> override name + url - added provision in admin to enable admin overrides - updated template to use newly added property - update existing prop to use override name + url
Very nice! I think the URL issue is okay since its based on their github name, so its not "wrong" per se, just not perfect - and changing it would be a big headache. @vs77bb @alexvotofuture what do y'all think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few questions but otherwise approved 👍 nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thelostone-mc we'll need to rename the migration to 0035 and fix, I have one for dashboard as well (lots of migrations this deploy) |
This reverts commit d21f61f.
Description
Steps
In this example -> assume we'd be updating metamask name to xyz and their logo
Update Profile (/profile/xyz)
Admin override name
to the new name (xyz)Admin override avatar:
^ This would ensure that the profile page of the org shows the overridden name + photo
Update Bounty (only for bounty + hackathon)
This is the tricky part.
Admin override org name
to the new name (xyz)Admin override org logo
^ This would ensure that the bounty details page of the org shows the overridden name + photo
These are temp fixes which will be removed out once orgs is built out as a feature
note: do not use this for non-hackathon bounties ( especially name change as the filters extra map to the actual Github name)
Demo: Check HERE