Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities in Navigation Bar #4644

Merged
merged 6 commits into from
Jul 27, 2019
Merged

Activities in Navigation Bar #4644

merged 6 commits into from
Jul 27, 2019

Conversation

kuhnchris
Copy link
Contributor

Description

Per @PixelantDesign 's direct request

Refers/Fixes

n/a

Testing

grafik

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #4644 into master will decrease coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
- Coverage   30.64%   30.02%   -0.63%     
==========================================
  Files         216      213       -3     
  Lines       17411    17098     -313     
  Branches     2364     2311      -53     
==========================================
- Hits         5336     5134     -202     
+ Misses      11860    11764      -96     
+ Partials      215      200      -15
Impacted Files Coverage Δ
app/marketing/management/commands/sync_mail.py 0% <0%> (-29.6%) ⬇️
app/grants/templatetags/grants_extra.py 71.42% <0%> (-28.58%) ⬇️
app/grants/models.py 49.67% <0%> (-8.16%) ⬇️
app/avatar/models.py 34.74% <0%> (-3.66%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/marketing/mails.py 11.52% <0%> (-2.39%) ⬇️
app/dashboard/router.py 32.7% <0%> (-1.97%) ⬇️
app/retail/emails.py 21.52% <0%> (-1.83%) ⬇️
app/dashboard/notifications.py 16.15% <0%> (-0.69%) ⬇️
app/economy/models.py 58% <0%> (-0.42%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee6e60...1d4ca4d. Read the comment docs.

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Jun 17, 2019

This is nit picky but could you change it to Activity Stream? :)

@kuhnchris
Copy link
Contributor Author

...but only because you asked so nice. ;-)
Added it

@thelostone-mc thelostone-mc merged commit 0d96b67 into gitcoinco:master Jul 27, 2019
@kuhnchris kuhnchris deleted the activities-in-nav branch July 27, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants