-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token warnings #4639
token warnings #4639
Conversation
@octavioamu isn't this already fixed in #4742 ? |
Codecov Report
@@ Coverage Diff @@
## master #4639 +/- ##
==========================================
+ Coverage 30.42% 31.67% +1.25%
==========================================
Files 216 213 -3
Lines 17276 19423 +2147
Branches 2345 2992 +647
==========================================
+ Hits 5256 6152 +896
- Misses 11811 13013 +1202
- Partials 209 258 +49
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4639 +/- ##
=======================================
Coverage 30.42% 30.42%
=======================================
Files 216 216
Lines 17276 17276
Branches 2345 2345
=======================================
Hits 5256 5256
Misses 11811 11811
Partials 209 209 Continue to review full report at Codecov.
|
fef373b
Description
warns the user upon posting a bounty if their
approve()
is not enoughRefers/Fixes
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1560434810014200
Testing
still need to test more
probably also need to tell the user if theres not enough balance.