Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token warnings #4639

Merged
merged 3 commits into from
Jul 17, 2019
Merged

token warnings #4639

merged 3 commits into from
Jul 17, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 13, 2019

Description

warns the user upon posting a bounty if their approve() is not enough

Refers/Fixes

https://gitcoincore.slack.com/archives/CAXQ7PT60/p1560434810014200

Testing

still need to test more
probably also need to tell the user if theres not enough balance.

@thelostone-mc
Copy link
Member

@octavioamu isn't this already fixed in #4742 ?

danlipert
danlipert previously approved these changes Jul 17, 2019
octavioamu
octavioamu previously approved these changes Jul 17, 2019
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #4639 into master will increase coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4639      +/-   ##
==========================================
+ Coverage   30.42%   31.67%   +1.25%     
==========================================
  Files         216      213       -3     
  Lines       17276    19423    +2147     
  Branches     2345     2992     +647     
==========================================
+ Hits         5256     6152     +896     
- Misses      11811    13013    +1202     
- Partials      209      258      +49
Impacted Files Coverage Δ
app/marketing/management/commands/sync_mail.py 0% <0%> (-29.17%) ⬇️
app/grants/templatetags/grants_extra.py 71.42% <0%> (-28.58%) ⬇️
app/dashboard/router.py 27.83% <0%> (-6.83%) ⬇️
app/marketing/mails.py 11.52% <0%> (-1.33%) ⬇️
app/economy/models.py 58% <0%> (-0.42%) ⬇️
app/dataviz/views.py 8.82% <0%> (-0.33%) ⬇️
app/grants/views.py 13.71% <0%> (-0.18%) ⬇️
app/app/settings.py 78.65% <0%> (-0.16%) ⬇️
app/retail/utils.py 10.31% <0%> (-0.03%) ⬇️
app/marketing/views.py 12% <0%> (-0.03%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be24ebc...b6a5b19. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #4639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4639   +/-   ##
=======================================
  Coverage   30.42%   30.42%           
=======================================
  Files         216      216           
  Lines       17276    17276           
  Branches     2345     2345           
=======================================
  Hits         5256     5256           
  Misses      11811    11811           
  Partials      209      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be24ebc...fef373b. Read the comment docs.

thelostone-mc
thelostone-mc previously approved these changes Jul 17, 2019
@octavioamu octavioamu dismissed stale reviews from thelostone-mc, danlipert, and themself via fef373b July 17, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants