Issue 3907 profile header update #4605

iamonuwa · 2019-06-10T10:13:32Z

Description

Added a new directory wallpapers inside the assets. It is where the banners will reside so that the api can load them dynamically.

Once a banner is selected, the path to the file is stored against the user's data

Refers/Fixes

Fixes #3907

Testing

Tested locally with the wallpapers on my machine

thelostone-mc

squash commits
better description
screenshot + video (should be attached in PR even if it's added in the issue )

iamonuwa · 2019-06-12T13:31:07Z

I'll squash the commit since it's part of another one. Add the videos as well.

…

On Wed, 12 Jun 2019, 14:27 Aditya Anand M C, ***@***.***> wrote: ***@***.**** requested changes on this pull request. - squash commits - better description - screenshot + video (should be attached in PR even if it's added in the issue ) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4605?email_source=notifications&email_token=ABR7MNXIYO46YKNBRULXBKTP2D2VVA5CNFSM4HWSGBQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3J4DMY#pullrequestreview-248758707>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABR7MNUVC4VMPE7JPM4HDI3P2D2VVANCNFSM4HWSGBQA> .

iamonuwa · 2019-06-12T15:40:07Z

@thelostone-mc @owocki @PixelantDesign @danlipert please take a look https://www.dropbox.com/s/t77huj1q0rnixrd/Banner%20Image.mp4?dl=0

owocki · 2019-06-12T15:46:39Z

thanks! looks like it's functionality working

does the 'update profile' button just show up if it's your own profile? is the endpoint secure such that people can't change each others profile images?
what about this part of the ticket?

Select an image from a list of preselected profile headers. Those profile headers are already created, and they are uploaded to this ticket.

we put a bunch of effort into getting these preselected profile headers together, so it'd be great to see them leveraged.
3. can we position the 'update profile' header on top of the profile header image itself (on the z axis), similar to the twitter example?

ref: #3907

iamonuwa · 2019-06-12T15:57:30Z

@owocki thanks for the quick review.

Just added the security flag to it.
I think of adding a modal with the pre-populated images on either aws or from the project locally + an option to do this. What do you think?
I don't understand this. Can you point it out for me?

codecov · 2019-06-12T16:03:40Z

Codecov Report

Merging #4605 into master will decrease coverage by 12.62%.
The diff coverage is 30%.

@@            Coverage Diff             @@
##           master   #4605       +/-   ##
==========================================
- Coverage   30.42%   17.8%   -12.63%     
==========================================
  Files         216     205       -11     
  Lines       17276   17229       -47     
  Branches     2345    2344        -1     
==========================================
- Hits         5256    3067     -2189     
- Misses      11811   14152     +2341     
+ Partials      209      10      -199

Impacted Files	Coverage Δ
app/app/urls.py	`0% <ø> (-89.37%)`	⬇️
app/dashboard/models.py	`37.93% <100%> (-17.76%)`	⬇️
app/dashboard/views.py	`11.45% <25%> (-2.96%)`	⬇️
app/dashboard/helpers.py	`11.89% <33.33%> (-2.01%)`	⬇️
app/kudos/forms.py	`0% <0%> (-100%)`	⬇️
app/grants/serializers.py	`0% <0%> (-100%)`	⬇️
app/avatar/serializers.py	`0% <0%> (-100%)`	⬇️
app/grants/urls.py	`0% <0%> (-100%)`	⬇️
app/inbox/urls.py	`0% <0%> (-100%)`	⬇️
app/avatar/urls.py	`0% <0%> (-100%)`	⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae1a6c...f0456c9. Read the comment docs.

owocki · 2019-06-12T16:09:45Z

@iamonuwa

awesome! glad we checked
either one makes sense to me. locally might be simpler, but i defer to you and dan.
checkout what this functionality looks like on twitter. basically we save space on the profile by not having the 'update image' button on the profile, but instead putting it above the cover photo itself.

iamonuwa · 2019-06-12T16:12:11Z

Awesome, for the update button profile I was trying to replicate the twitter's Edit Profile button. Once you click on it, it should give you the Change your header photo. Anywhere around the background will open up the modal in the case of 1.

@owocki

owocki · 2019-06-12T16:16:28Z

thanks for the update. i probably sould have specified better in the ticket. i think having the 'update your profile header' onload (IFF the user is looking at their own profile) is a better ux

iamonuwa · 2019-06-12T16:21:53Z

thanks for the update. i probably sould have specified better in the ticket. i think having the 'update your profile header' onload (IFF the user is looking at their own profile) is a better ux

Understood, ATM the currently logged in user alone sees the button

iamonuwa · 2019-06-13T14:28:01Z

@thelostone-mc @owocki @PixelantDesign @danlipert new update. I've taken care of the changes. Please take a look. https://www.dropbox.com/s/pt7ia6jqixdlana/Header%20Image.mp4?dl=0

iamonuwa · 2019-06-13T16:22:04Z

Currently having issue pushing updates to GitHub. Will keep trying

owocki · 2019-06-13T19:29:50Z

looking good!

can we remove the 'update profile' button and instead just always have the ability to update our own header images?
if i add an image, does that make it avaialble only to me, or to everyone on the platfrom? im a little worried about ppl uploading inappropriate images.

iamonuwa · 2019-06-13T19:53:59Z

looking good!

can we remove the 'update profile' button and instead just always have the ability to update our own header images?

if i add an image, does that make it avaialble only to me, or to everyone on the platfrom? im a little worried about ppl uploading inappropriate images.

Personally, I think the current implementation is a better UX except if I don't get what you mean. Not cool to show the Change your header photo once I open my profile.
Its public. We can force everyone to use the platform specific banners if that will solve the inappropriate images issue.

owocki · 2019-06-13T20:09:21Z

ok that works
i like that suggestion

iamonuwa · 2019-06-13T20:15:33Z

i like that suggestion

Am going to remove user file upload, everyone has to use Gitcoin's preselected banners

iamonuwa · 2019-06-13T20:33:56Z

@thelostone-mc @owocki @PixelantDesign @danlipert https://www.dropbox.com/s/gajc8whcgw5075z/Gitcoin%20Header.mp4?dl=0

owocki · 2019-06-13T22:45:38Z

can we preload the banners we designed into the modal?

…

On Thu, Jun 13, 2019 at 4:33 PM Onuwa Nnachi Isaac ***@***.***> wrote: @thelostone-mc <https://github.com/thelostone-mc> @owocki <https://github.com/owocki> @PixelantDesign <https://github.com/PixelantDesign> @danlipert <https://github.com/danlipert> https://www.dropbox.com/s/gajc8whcgw5075z/Gitcoin%20Header.mp4?dl=0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4605?email_source=notifications&email_token=AAD5PCKL4XLDTNDXSGPXPDTP2KVLLA5CNFSM4HWSGBQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXU6PEY#issuecomment-501868435>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD5PCN5R7BVUR4ECP3QY2LP2KVLLANCNFSM4HWSGBQA> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ check out what i'm building on github <http://github.com/owocki> or what i'm shooting on photoshelter <http://photography.owocki.com/> or find me on twitter <http://www.twitter.com/owocki>, facebook <http://www.facebook.com/kevinowocki>, instagram <http://instagram.com/owocki>, linkedin <http://www.linkedin.com/in/owocki>, and owocki.com <http://www.owocki.com/?utm_source=emailsig>. see you around teh internets! PS -- Come to the next Boulder Blockchain <https://www.meetup.com/Boulder-Blockchain/> meetup. Be there or be ^ 2. PPS -- Have I mentioned that *G**itcoin is live?* More @ https://gitcoin.co

iamonuwa · 2019-06-13T23:55:00Z

can we preload the banners we designed into the modal?

Just load the files into the wallpapers directory. Its located inside the assets directory. Relax and watch the magic happen. 😂🔥🔥🔥🔥🔥

iamonuwa · 2019-06-14T11:27:41Z

@thelostone-mc @owocki @octavioamu ready for review

app/dashboard/templates/profiles/profile.html

owocki · 2019-06-14T15:07:04Z

Just load the files into the wallpapers directory. Its located inside the assets directory. Relax and watch the magic happen. 😂🔥🔥🔥🔥🔥

shouldnt that be part of this PR?

iamonuwa · 2019-06-14T15:13:09Z

Just load the files into the wallpapers directory. Its located inside the assets directory. Relax and watch the magic happen. joyfirefirefirefirefire

shouldnt that be part of this PR?

I have a sample inside the directory. I can add the available ones from the creatives repo. Moving forward, that's where the wallpapers will live

owocki · 2019-06-14T15:18:58Z

Thx pls do

…

On Fri, Jun 14, 2019 at 9:13 AM Onuwa Nnachi Isaac ***@***.***> wrote: Just load the files into the wallpapers directory. Its located inside the assets directory. Relax and watch the magic happen. joyfirefirefirefirefire shouldnt that be part of this PR? I have a sample inside the directory. I can add the available ones from the creatives repo. Moving forward, that's where the wallpapers will live — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4605?email_source=notifications&email_token=AAD5PCK55FGTY4INYJ4NU2TP2OYQLA5CNFSM4HWSGBQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXCVLQ#issuecomment-502147758>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD5PCJ67XATMXJ7W2FKYNTP2OYQLANCNFSM4HWSGBQA> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ check out what i'm building on github <http://github.com/owocki> or what i'm shooting on photoshelter <http://photography.owocki.com/> or find me on twitter <http://www.twitter.com/owocki>, facebook <http://www.facebook.com/kevinowocki>, instagram <http://instagram.com/owocki>, linkedin <http://www.linkedin.com/in/owocki>, and owocki.com <http://www.owocki.com/?utm_source=emailsig>. see you around teh internets! PS -- Come to the next Boulder Blockchain <https://www.meetup.com/Boulder-Blockchain/> meetup. Be there or be ^ 2. PPS -- Have I mentioned that *G**itcoin is live?* More @ https://gitcoin.co

iamonuwa · 2019-06-14T15:37:13Z

@octavioamu

iamonuwa · 2019-06-14T15:45:43Z

@owocki do you want to support gifs? That will need extra engineering. What do you think?

iamonuwa · 2019-06-14T16:05:22Z

@owocki @PixelantDesign @octavioamu @thelostone-mc please take a look at the changes https://www.dropbox.com/s/qdpfwaclfofv1qt/Header%20Image%20Update.mp4?dl=0

author Onuwa Nnachi Isaac <[email protected]> 1559984848 +0100 committer Onuwa Nnachi Isaac <[email protected]> 1560939145 +0100 Fix profile banner

app/assets/v2/js/pages/profile.js

app/dashboard/views.py

owocki · 2019-07-10T01:55:37Z

very excited for this to finally go live!

danlipert · 2019-07-17T14:03:07Z

@octavioamu please review

octavioamu

lgtm

owocki · 2019-07-17T16:50:28Z

i get this expection when trying to run on my local:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/django/contrib/staticfiles/handlers.py", line 65, in __call__
    return self.application(environ, start_response)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/wsgi.py", line 142, in __call__
    response = self.get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 78, in get_response
    response = self._middleware_chain(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
    response = response_for_exception(request, exc)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
    response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 125, in handle_uncaught_exception
    return debug.technical_500_response(request, *exc_info)
  File "/usr/local/lib/python3.7/site-packages/django_extensions/management/technical_response.py", line 37, in null_technical_500_response
    six.reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.7/site-packages/six.py", line 692, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/code/app/dashboard/views.py", line 1746, in load_banners
    images = load_files_in_directory('wallpapers')
  File "/code/app/dashboard/helpers.py", line 59, in load_files_in_directory
    for f in os.listdir(path):
FileNotFoundError: [Errno 2] No such file or directory: '/code/app/static/wallpapers'

owocki · 2019-07-17T16:51:25Z

note that i have not run collectstatic, and neither will the production servers have run it (there are multiple boxes and only ONE will run collectstatic on it)

danlipert · 2019-07-22T15:00:08Z

Just for posterity, when this got rolled to production I created the folder manually and touched the filenames on each server

thelostone-mc requested changes Jun 12, 2019

View reviewed changes

iamonuwa changed the title ~~WIP Issue 3907 profile header update~~ Issue 3907 profile header update Jun 12, 2019

gitcoinbot mentioned this pull request Jun 14, 2019

CODE - As a user, I want to be able to update my profile header, to further customize my profile 'when I look in the mirror'. #3907

Closed

octavioamu approved these changes Jun 14, 2019

View reviewed changes

app/dashboard/templates/profiles/profile.html Outdated Show resolved Hide resolved

octavioamu suggested changes Jun 14, 2019

View reviewed changes

app/dashboard/templates/profiles/profile.html Outdated Show resolved Hide resolved

iamonuwa added 6 commits June 25, 2019 00:28

Update changes

8ff5fa4

Remove all upload logic. Send file_path instead

463c786

Update changes

5f87d7b

parent cdb2486

020aa8a

author Onuwa Nnachi Isaac <[email protected]> 1559984848 +0100 committer Onuwa Nnachi Isaac <[email protected]> 1560939145 +0100 Fix profile banner

Update changes

b6a9f5a

Update changes

07796ae

PixelantDesign added the sprint 13 label Jun 25, 2019

thelostone-mc requested a review from danlipert July 3, 2019 13:07

danlipert suggested changes Jul 3, 2019

View reviewed changes

app/assets/v2/js/pages/profile.js Outdated Show resolved Hide resolved

app/dashboard/views.py Outdated Show resolved Hide resolved

Update changes

0f9ae06

danlipert previously approved these changes Jul 10, 2019

View reviewed changes

thelostone-mc previously approved these changes Jul 17, 2019

View reviewed changes

Merge branch 'master' into issue-3907-profile-header-update

099e5ed

Merge branch 'master' into issue-3907-profile-header-update

2b5845e

octavioamu dismissed stale reviews from thelostone-mc and danlipert via 2b5845e July 17, 2019 14:16

octavioamu previously approved these changes Jul 17, 2019

View reviewed changes

danlipert and others added 3 commits July 17, 2019 07:55

Merge branch 'master' into issue-3907-profile-header-update

c75e1fa

Merge branch 'master' into issue-3907-profile-header-update

3abb2d4

recreated migration file

f0456c9

thelostone-mc dismissed octavioamu’s stale review via f0456c9 July 17, 2019 15:13

thelostone-mc approved these changes Jul 17, 2019

View reviewed changes

danlipert merged commit 6077f2d into gitcoinco:master Jul 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 3907 profile header update #4605

Issue 3907 profile header update #4605

iamonuwa commented Jun 10, 2019 •

edited

Loading

thelostone-mc left a comment

iamonuwa commented Jun 12, 2019 via email

iamonuwa commented Jun 12, 2019

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019

codecov bot commented Jun 12, 2019 •

edited

Loading

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019 •

edited

Loading

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019

iamonuwa commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019 via email

iamonuwa commented Jun 13, 2019 •

edited

Loading

iamonuwa commented Jun 14, 2019

owocki commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

owocki commented Jun 14, 2019 via email

iamonuwa commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

owocki commented Jul 10, 2019

danlipert commented Jul 17, 2019

octavioamu left a comment

owocki commented Jul 17, 2019

owocki commented Jul 17, 2019

danlipert commented Jul 22, 2019

Issue 3907 profile header update #4605

Issue 3907 profile header update #4605

Conversation

iamonuwa commented Jun 10, 2019 • edited Loading

Description

Refers/Fixes

Testing

thelostone-mc left a comment

Choose a reason for hiding this comment

iamonuwa commented Jun 12, 2019 via email

iamonuwa commented Jun 12, 2019

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019

codecov bot commented Jun 12, 2019 • edited Loading

Codecov Report

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019 • edited Loading

owocki commented Jun 12, 2019

iamonuwa commented Jun 12, 2019

iamonuwa commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

iamonuwa commented Jun 13, 2019

owocki commented Jun 13, 2019 via email

iamonuwa commented Jun 13, 2019 • edited Loading

iamonuwa commented Jun 14, 2019

owocki commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

owocki commented Jun 14, 2019 via email

iamonuwa commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

iamonuwa commented Jun 14, 2019

owocki commented Jul 10, 2019

danlipert commented Jul 17, 2019

octavioamu left a comment

Choose a reason for hiding this comment

owocki commented Jul 17, 2019

owocki commented Jul 17, 2019

danlipert commented Jul 22, 2019

iamonuwa commented Jun 10, 2019 •

edited

Loading

codecov bot commented Jun 12, 2019 •

edited

Loading

iamonuwa commented Jun 12, 2019 •

edited

Loading

iamonuwa commented Jun 13, 2019 •

edited

Loading