Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rating duplication in profile #4592

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

Description
Refers/Fixes

Fix: #4343 #4354 #4342

Testing

@octavioamu octavioamu requested a review from danlipert June 7, 2019 16:53
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #4592 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
+ Coverage   30.09%   30.12%   +0.03%     
==========================================
  Files         211      211              
  Lines       16954    16957       +3     
  Branches     2290     2291       +1     
==========================================
+ Hits         5102     5108       +6     
+ Misses      11654    11651       -3     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/views.py 14.17% <0%> (-0.04%) ⬇️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e890a5a...16d7221. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #4592 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
- Coverage   30.12%   30.12%   -0.01%     
==========================================
  Files         210      210              
  Lines       16911    16914       +3     
  Branches     2284     2285       +1     
==========================================
  Hits         5095     5095              
- Misses      11619    11622       +3     
  Partials      197      197
Impacted Files Coverage Δ
app/dashboard/views.py 14.25% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17efb5...7907951. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good 👍

if not settings.DEBUG:
network = 'mainnet'
else:
network = 'rinkeby'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiceeee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - After Completion Ratings - Rinkeby Bounties are counted in.
3 participants