Dashboard #4588
Dashboard #4588
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
- Coverage 30.7% 30.63% -0.07%
==========================================
Files 216 216
Lines 17431 17488 +57
Branches 2365 2385 +20
==========================================
+ Hits 5352 5358 +6
- Misses 11864 11914 +50
- Partials 215 216 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 30.12% 30.18% +0.05%
==========================================
Files 210 215 +5
Lines 16911 16952 +41
Branches 2284 2286 +2
==========================================
+ Hits 5095 5117 +22
- Misses 11619 11638 +19
Partials 197 197
Continue to review full report at Codecov.
|
|
just pulled this down + been playing with it. nice work, coming along very well! some feedback. some nitpicky.. trying to focus on 'attention to detail' funder dashboard feeedbackspeed / performance is wayyy better than i expected for my user (owocki) that has many bounties :) these buttons seem misaligned http://bits.owocki.com/32a9ed53dcd2/Image%202019-07-29%20at%203.00.51%20PM.png i ahve 130 open bounties . its hard to scroll past them all. maybe set a max-height and a y-scroll on this div? feature/invite buttons point to http://localhost:8000/dashboard/bounty/change/4715/ which seeems to 404 for me.. inconsistent capitalization here and “0 applicantions” is (1) spelled wron. http://bits.owocki.com/954d2d34aae1/Image%202019-07-29%20at%203.02.10%20PM.png i dont think that the ‘accept/reject’ buttons are correctly showing on my pending bounties because i get this screen when i click ‘accept’ http://bits.owocki.com/786cf2ae1f70/Image%202019-07-29%20at%203.03.03%20PM.png -- it should likely only show applicants who are in a pending state (not already approved) i think that the ‘feature bounty ‘and ‘invite contributors’ buttons should show up for all 3 categories of bounties. its possible that i’m not happy with the marketing of my bounties in all three scenarios (open bounties, submitted bounties, expired bounties) there shoudl possibly also be a ‘contact the gitcoin core team’ button on these rows, in case the self service stuff isnt’ working. title should be capitalized http://bits.owocki.com/512ce47c9140/Image%202019-07-29%20at%203.05.44%20PM.png responsive css could use a little love http://bits.owocki.com/3b2dfa7e0f70/Image%202019-07-29%20at%203.06.16%20PM.png theres a bunch of empty space up here ( http://bits.owocki.com/e0c0c20739b2/Image%202019-07-29%20at%203.06.29%20PM.png ) is that by design? contributor dashboard‘stop work’ has no callback -- no indicator of success when the HTTP request responds http://bits.owocki.com/bbb4677ee3e1/Screen%20Recording%202019-07-29%20at%2003.07%20PM.gif |
|
Thanks @owocki I work in that fixes! |
|
@owocki all done except for:
I wasn't able to reproduce, I think can be related to the db? the query just do exactly that looks for open bounties . What bounty type is the one on your print?
There is a very small space right now so for that a redesign will be needed
I think this need to be solved with the zendesk or any more global solution instead of here, but anyway I let that for the design team. |
its not a bounty type, its a bounty.interests thing. we need bounty.interests.filter(pending=True) on it |
|
I will check it don't know what is happening with github my last commit is not here db1f71d |
At least now the commit link is working |
|
@owocki added the pending filter, now should be good. |
app/app/tests/test_app_urls.py
Outdated
| """Test the dashboard url and check the resolution.""" | ||
| self.assertEqual(resolve('/dashboard').view_name, 'dashboard') | ||
| self.assertEqual(resolve('/dashboard/').view_name, 'dashboard') | ||
| # def test_dashboard_reverse(self): |
There was a problem hiding this comment.
should we just remove these?
Description
OPEN BOUNTIES (applicants)
BOUNTY SUBMISSIONS (applicants)
EXPIRED BOUNTIES
BOUNTIES IN PROGRESS
BOUNTIES APPLIED
WORK SUBMITTED
General notes:
"view applicants" only request data on click the first time is clicked
Each dashboard (funder, contributors) only request data when the tab is clicked
Both have a loading state and empty data.
The default tab is "funder" but if you have a persona "hunter" it will be contributor tab.
Refers/Fixes
ref #4153
Fix #4754
Testing
https://embed.vidyard.com/share/JBaBMgybeaqdVnQuFqnJNn?