Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter 2019-06-07 #4587

Merged
merged 1 commit into from
Jun 6, 2019
Merged

newsletter 2019-06-07 #4587

merged 1 commit into from
Jun 6, 2019

Conversation

rmshea
Copy link
Contributor

@rmshea rmshea commented Jun 6, 2019

Description

yo yo, new newsletter!

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #4587 into stable will increase coverage by 12.39%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           stable    #4587       +/-   ##
===========================================
+ Coverage   17.73%   30.12%   +12.39%     
===========================================
  Files         200      210       +10     
  Lines       16924    16911       -13     
  Branches     2295     2284       -11     
===========================================
+ Hits         3002     5095     +2093     
+ Misses      13912    11619     -2293     
- Partials       10      197      +187
Impacted Files Coverage Δ
app/retail/emails.py 21.52% <0%> (+2.2%) ⬆️
app/grants/admin.py 41.97% <0%> (-0.71%) ⬇️
app/marketing/stats.py 0% <0%> (ø) ⬆️
app/avatar/utils.py 13.19% <0%> (ø) ⬆️
...board/management/commands/cleanup_dupe_bounties.py
app/retail/templatetags/is_in_list.py 100% <0%> (ø)
app/kudos/templatetags/kudos_extras.py 70% <0%> (ø)
app/retail/templatetags/strip_char.py 57.14% <0%> (ø)
app/retail/templatetags/is_in_list_type_iexact.py 66.66% <0%> (ø)
app/grants/templatetags/grants_extra.py 71.42% <0%> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8186c9...99a15c1. Read the comment docs.

@thelostone-mc thelostone-mc changed the base branch from master to stable June 6, 2019 01:29
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-shea sweet commit message :P
PS: newletter PR goes into stable cause that's the branch we deploy.

Going forward could you raise the PR to that 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants