Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: fix undefined error #4583

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Conversation

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #4583 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4583      +/-   ##
==========================================
- Coverage   30.12%   30.09%   -0.04%     
==========================================
  Files         211      211              
  Lines       16954    16954              
  Branches     2290     2290              
==========================================
- Hits         5108     5102       -6     
- Misses      11648    11654       +6     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd1a63...4184942. Read the comment docs.

@thelostone-mc thelostone-mc requested a review from a team June 5, 2019 17:25
@thelostone-mc thelostone-mc added the 1 label Jun 6, 2019
@thelostone-mc thelostone-mc self-assigned this Jun 6, 2019
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but how was it tested?

@thelostone-mc
Copy link
Member Author

@danlipert -> checking on which page the error appears -> recreate the same env and fix the error
All of them add an extra if check which would otherwise through undefined if it continued execution

@danlipert
Copy link
Contributor

@thelostone-mc Sounds good but I worry that in squashing these alarms, we may introduce additional issues so I think it needs some solid manual testing. I'm down to do it in pre-deploy regression tests though, what do you think?

danlipert
danlipert previously approved these changes Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants