-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry: fix undefined error #4583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4583 +/- ##
==========================================
- Coverage 30.12% 30.09% -0.04%
==========================================
Files 211 211
Lines 16954 16954
Branches 2290 2290
==========================================
- Hits 5108 5102 -6
- Misses 11648 11654 +6
Partials 198 198
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but how was it tested?
@danlipert -> checking on which page the error appears -> recreate the same env and fix the error |
@thelostone-mc Sounds good but I worry that in squashing these alarms, we may introduce additional issues so I think it needs some solid manual testing. I'm down to do it in pre-deploy regression tests though, what do you think? |
Fixes