makes grant info calculation imdipident #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlipert
suggested changes
Jun 5, 2019
| @@ -659,14 +661,17 @@ def get_converted_amount(self): | |||
| return None | |||
|
|
|||
| def get_converted_monthly_amount(self): | |||
| converted_amount = self.get_converted_amount() | |||
| if self.num_tx_approved == 1: | |||
There was a problem hiding this comment.
Whats this line for? Checking if its a one-time contribution?
app/grants/models.py
Outdated
|
|
||
| instance.amount_received = 0 | ||
| instance.monthly_amount_subscribed = 0 | ||
| print(instance.id) |
app/grants/models.py
Outdated
|
|
||
| if subscription.num_tx_processed <= subscription.num_tx_approved and value_usdt: | ||
| instance.monthly_amount_subscribed += subscription.get_converted_monthly_amount() | ||
| print("-", subscription.id, value_usdt, instance.monthly_amount_subscribed ) |
There was a problem hiding this comment.
another print :) if we want these, lets use the logger 👍
Codecov Report
@@ Coverage Diff @@
## stable #4582 +/- ##
==========================================
- Coverage 17.58% 17.57% -0.01%
==========================================
Files 200 200
Lines 17070 17129 +59
Branches 2320 2345 +25
==========================================
+ Hits 3002 3011 +9
- Misses 14056 14103 +47
- Partials 12 15 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makes grant info calculation imdipident
this makes debugging / correcting thte grant detail information much easier, since you don't have to reason about when the callback functions were calculated. you just construct the info from state everytime you calc it.
Refers/Fixes
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1559671421017900
Testing
tested it locally. http://bits.owocki.com/424bf1731bfb/Image%202019-06-04%20at%208.02.04%20PM.png