-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4503 - Add canonical URL to Bounty Details template #4579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4579 +/- ##
==========================================
- Coverage 30.12% 30.12% -0.01%
==========================================
Files 210 210
Lines 16911 16917 +6
Branches 2284 2284
==========================================
+ Hits 5095 5096 +1
- Misses 11619 11624 +5
Partials 197 197
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4579 +/- ##
==========================================
- Coverage 30.06% 30.05% -0.01%
==========================================
Files 213 213
Lines 17098 17106 +8
Branches 2311 2311
==========================================
+ Hits 5140 5141 +1
- Misses 11758 11765 +7
Partials 200 200
Continue to review full report at Codecov.
|
Actually (and I'm no SEO expert obviously), I'm thinking that the canonical urls need to be absolute (not relative). Will look at making them so. |
7be767d
to
2a4d344
Compare
Ready for review |
@danlipert Any review or feedback would be appreciated, cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ^_^
@proofoftom very nice! |
Description
Added a reverse lookup of the bounty which provides a canonical URL sans the standard bounties id (i.e.
/issue/gitcoinco/web/12
)Refers/Fixes
Fixes #4503
Testing
Added tests for the
bounty.canonical_url
property