Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localstorage to trigger funder onboarding #4560

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

thelostone-mc
Copy link
Member

Description

uses localStorage to identify if user has gone through
funder onboarding process and accordingly update the
fund this issue link on the landing

fixes: #4436

DEMO : SEE HERE

uses localStorage to identify if user has gone through
funder onboarding process and accordingly update the
fund this issue link on the landing

fixes: gitcoinco#4436
@thelostone-mc thelostone-mc requested review from frankchen07 and a team June 2, 2019 07:46
@thelostone-mc thelostone-mc self-assigned this Jun 2, 2019
@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #4560 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4560      +/-   ##
==========================================
+ Coverage   30.12%   30.12%   +<.01%     
==========================================
  Files         210      210              
  Lines       16914    16911       -3     
  Branches     2285     2284       -1     
==========================================
  Hits         5095     5095              
+ Misses      11622    11619       -3     
  Partials      197      197
Impacted Files Coverage Δ
app/retail/views.py 29.12% <ø> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6257b3...e4de47d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #4560 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4560      +/-   ##
==========================================
- Coverage   30.12%   30.09%   -0.04%     
==========================================
  Files         210      210              
  Lines       16914    16911       -3     
  Branches     2285     2284       -1     
==========================================
- Hits         5095     5089       -6     
- Misses      11622    11625       +3     
  Partials      197      197
Impacted Files Coverage Δ
app/retail/views.py 29.12% <ø> (+0.28%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6257b3...5356bd2. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Extremely clean!

@danlipert danlipert changed the title feat: ftux improv Use localstorage to trigger funder onboarding Jun 3, 2019
@danlipert danlipert merged commit b17efb5 into gitcoinco:master Jun 3, 2019
@thelostone-mc thelostone-mc deleted the ftux branch July 4, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funder FTUX Enhancements
2 participants