Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-invite user #4472

Closed
wants to merge 5 commits into from
Closed

re-invite user #4472

wants to merge 5 commits into from

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented May 23, 2019

Description
  • added button (auto-trigger) when invite param is passed in /user
  • if user has no bounties to invite hunter -> they are encouraged
    to create bounty
  • update waiting-page to show invite user for basic & advanced payout
  • refactor styling + indent + html
Demo

Basic Payout : Check HERE
Advanced Payout : Check HERE

closes #4333

if user has no bounties to invite hunter -> they are encouraged
to create bounty
- added button (auto-trigger) when invite param is passed in /user
- bounty waiting state shows invite user based on sessionStorage
- fixed linting issues + added documentation
@thelostone-mc thelostone-mc marked this pull request as ready for review May 26, 2019 08:26
@thelostone-mc thelostone-mc requested review from frankchen07, vs77bb and a team May 26, 2019 08:27
@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #4472 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
+ Coverage   30.08%   30.09%   +<.01%     
==========================================
  Files         209      209              
  Lines       16850    16848       -2     
  Branches     2267     2266       -1     
==========================================
  Hits         5070     5070              
+ Misses      11582    11580       -2     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/views.py 14.53% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5697255...9003f34. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #4472 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
+ Coverage   30.08%   30.09%   +<.01%     
==========================================
  Files         209      209              
  Lines       16850    16848       -2     
  Branches     2267     2266       -1     
==========================================
  Hits         5070     5070              
+ Misses      11582    11580       -2     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/views.py 14.53% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5697255...9003f34. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but lets sync about this

setTimeout(function() {
$('#reinvite-user').trigger('click');
}, 200);
clearInterval(timer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this you can user the vm methods this.openBounties(reinviteUser), you don't need to go to trigger from the view.

@thelostone-mc
Copy link
Member Author

Ported commits over to #4494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build - Backend Working Together Again
2 participants