Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add previously worked label in user directory #4455

Merged
merged 4 commits into from
May 22, 2019

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented May 22, 2019

Description

Add the previously worked label
Screen Shot 2019-05-22 at 4 15 03 PM

Refers/Fixes

Fixes #4410

Testing

@SaptakS SaptakS requested a review from octavioamu May 22, 2019 11:23
octavioamu
octavioamu previously approved these changes May 22, 2019
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #4455 into master will decrease coverage by 0.28%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4455      +/-   ##
==========================================
- Coverage   30.12%   29.84%   -0.29%     
==========================================
  Files         208      208              
  Lines       16791    16796       +5     
  Branches     2255     2256       +1     
==========================================
- Hits         5059     5012      -47     
- Misses      11537    11605      +68     
+ Partials      195      179      -16
Impacted Files Coverage Δ
app/dashboard/views.py 12.35% <33.33%> (-1.92%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/economy/models.py 58% <0%> (-3%) ⬇️
app/dashboard/models.py 55.63% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ae6ce...c36d1d3. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #4455 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4455      +/-   ##
==========================================
+ Coverage   30.12%   30.14%   +0.01%     
==========================================
  Files         208      208              
  Lines       16791    16798       +7     
  Branches     2255     2257       +2     
==========================================
+ Hits         5059     5063       +4     
- Misses      11537    11538       +1     
- Partials      195      197       +2
Impacted Files Coverage Δ
app/dashboard/views.py 14.51% <50%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc738b...c6e0c0b. Read the comment docs.

@SaptakS SaptakS force-pushed the user-directory/previously-worked branch from c36d1d3 to f15acab Compare May 22, 2019 13:47
@SaptakS SaptakS force-pushed the user-directory/previously-worked branch from f15acab to 1363c17 Compare May 22, 2019 13:56
@danlipert danlipert merged commit 10fd265 into gitcoinco:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Directory Build - Backend - Previously Worked With You label
3 participants