Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftux: improvements #4449

Merged
merged 4 commits into from
May 22, 2019
Merged

ftux: improvements #4449

merged 4 commits into from
May 22, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented May 21, 2019

Description
  • added login decorator for fund bounty page
  • refactored quickstart css + updated title
Refers

closes #4436

- added login decorator for fund bounty page
- refactored quickstart css + updated title
@thelostone-mc thelostone-mc marked this pull request as ready for review May 22, 2019 13:08
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #4449 into master will decrease coverage by 0.04%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4449      +/-   ##
==========================================
- Coverage   30.12%   30.08%   -0.05%     
==========================================
  Files         208      208              
  Lines       16791    16797       +6     
  Branches     2255     2257       +2     
==========================================
- Hits         5059     5053       -6     
- Misses      11537    11549      +12     
  Partials      195      195
Impacted Files Coverage Δ
app/retail/views.py 28.66% <14.28%> (-0.56%) ⬇️
app/dashboard/views.py 14.27% <50%> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc738b...c895892. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #4449 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4449      +/-   ##
==========================================
- Coverage   30.09%   30.05%   -0.05%     
==========================================
  Files         209      209              
  Lines       16846    16850       +4     
  Branches     2266     2267       +1     
==========================================
- Hits         5070     5064       -6     
- Misses      11578    11588      +10     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/views.py 14.51% <100%> (ø) ⬆️
app/retail/views.py 28.84% <20%> (-0.38%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6fdf6...ac5e2d8. Read the comment docs.

@thelostone-mc thelostone-mc requested a review from a team May 22, 2019 14:33
@danlipert danlipert merged commit 7efff2b into gitcoinco:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funder FTUX Enhancements
3 participants