Newsletter switch

[octavioamu]

Description

Refers/Fixes

#4413

Testing

[octavioamu]

waiting new forms links
@frankchen07 @PixelantDesign

[codecov]

Codecov Report

Merging #4448 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4448   +/-   ##
======================================
  Coverage    30.3%   30.3%           
======================================
  Files         214     214           
  Lines       17142   17142           
  Branches     2319    2319           
======================================
  Hits         5195    5195           
  Misses      11740   11740           
  Partials      207     207

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2098f26...02bfe4c. Read the comment docs.

[octavioamu]

@gitcoinco/engineers Ready to review!!

[danlipert]

@octavioamu looks good to me - how was it tested?

[thelostone-mc]

^ @danlipert testing it is as simple as clicking on the tab and ensuring the subscribe button open the right form I believe!

cc @octavioamu

[thelostone-mc]

@octavioamu looks like the styling hasn't been applied

Also, it redirects to bad page when I click on subscribe without entering name

http://consensys.us11.list-manage.com/subscribe/post?u=947c9b18fc27e0b00fc2ad055&id=d870d1315e

[octavioamu]

@thelostone-mc remember always to hard reload the browser to see the changes, here is a video https://embed.vidyard.com/share/1xuruC2LraV2ghEM482m2d?

[octavioamu]

@thelostone-mc I had added validation

[thelostone-mc]

sweet

[danlipert]

@thelostone-mc @octavioamu I ask just because the PR description didn't have any testing info - its a good way for us to double check as well as see what assumptions the PR creator is making during testing. Remember to hold off on merging until Aditya and I both review.