Exclude bounties reserved for specific users from new bounties email #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4426 +/- ##
==========================================
+ Coverage 30.13% 30.13% +<.01%
==========================================
Files 208 208
Lines 16787 16784 -3
Branches 2254 2253 -1
==========================================
Hits 5058 5058
+ Misses 11535 11532 -3
Partials 194 194
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4426 +/- ##
==========================================
+ Coverage 30.02% 30.17% +0.14%
==========================================
Files 209 209
Lines 16886 16886
Branches 2278 2278
==========================================
+ Hits 5070 5095 +25
+ Misses 11619 11594 -25
Partials 197 197
Continue to review full report at Codecov.
|
acolytec3
changed the title
acolytec3
changed the title
danlipert
suggested changes
May 29, 2019
app/marketing/tests/management/commands/test_new_bounty_email.py
Outdated
Show resolved
Hide resolved
danlipert
approved these changes
May 31, 2019
|
Ah, okay! Learn something new every day. Thanks!
…On Fri, May 31, 2019 at 7:29 AM Dan Lipert ***@***.***> wrote:
Merged #4426 <#4426> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4426?email_source=notifications&email_token=AEENFXABFIB2Y25W5E62ZCTPYED3JA5CNFSM4HNRL32KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORXTQX5A#event-2380729332>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEENFXCTRC5NK4WHIVIDGXTPYED3JANCNFSM4HNRL32A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current new bounties email includes bounties reserved for specific users which is annoying because reserved bounties aren't actually actually available to the general Gitcoin population. This PR adds an exclusion rule to the query that pulls relevant bounties to ensure that only bounties a user can actually apply for are included.
Refers/Fixes
Addresses one element of #4308
Testing
Adds new test for new_bounties_email.py that incorporates test for new exclusion of reserved bounties from email.