grant: update grant amount design #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4371 +/- ##
==========================================
- Coverage 30.19% 30.16% -0.04%
==========================================
Files 209 209
Lines 16790 16790
Branches 2249 2249
==========================================
- Hits 5070 5064 -6
- Misses 11527 11533 +6
Partials 193 193
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4371 +/- ##
==========================================
- Coverage 30.19% 30.16% -0.04%
==========================================
Files 209 209
Lines 16790 16790
Branches 2249 2249
==========================================
- Hits 5070 5064 -6
- Misses 11527 11533 +6
Partials 193 193
Continue to review full report at Codecov.
|
- fix breaking UI for wallet address - hide fund grant button for grant owner - updated grant amount view on grant/detail & landing. - removed outdated text from CLR matching
thelostone-mc
force-pushed
the
grant_detail
branch
from
f868dbf to
c61b0ed
Compare
|
^ rebased + resolved conflicts 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
#4169
DEMO : https://embed.vidyard.com/share/UyCNzrLwuKU9j3uJaqu5oD?
cc @danlipert / @frankchen07 the UI has been updated but I'm confused on how the calculation is done right now ! I haven't updated the backend logic but instead used the fields from grant model to populate it (how it's currently done )!
@danlipert mind helping me out validating and updating the values if necessary?